-
Notifications
You must be signed in to change notification settings - Fork 2
bump version to 0.55.7 to import library update to v0.44.10 #302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughBumps integration to 0.55.7 and plugwise-usb requirement to 0.44.10; adds a changelog entry. Also minor code cleanups: switch Callable import to collections.abc and simplify attribute access in event handling. No behavioral or public API changes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested reviewers
Poem
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
custom_components/plugwise_usb/event.py (1)
144-145: Direct attribute access is fine; consider a small defensive guardSwitching from getattr(...) to direct access is clearer and equivalent if data always has both attributes. If upstream ever omits one, this raises AttributeError. Consider a lightweight guard.
- state_value = data.state - group_value = data.group + try: + state_value = data.state + group_value = data.group + except AttributeError: + _LOGGER.debug( + "Event data missing 'state' or 'group' for %s", self._node_info.mac + ) + returnPlease confirm that for NodeFeature.SWITCH the coordinator-provided data object always includes both .state and .group across all supported firmware versions.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
custom_components/plugwise_usb/coordinator.py(1 hunks)custom_components/plugwise_usb/event.py(2 hunks)
🔇 Additional comments (2)
custom_components/plugwise_usb/coordinator.py (1)
4-4: Move Callable to collections.abc is correct and preferredGood cleanup. Importing Callable from collections.abc aligns with modern typing in Python 3.10+ and Home Assistant’s style. No runtime impact expected.
Also applies to: 7-7
custom_components/plugwise_usb/event.py (1)
12-16: Import hygiene looks goodRemoving unused imports and keeping only Platform is tidy and reduces lint noise. Event imports remain correct.



Summary by CodeRabbit
Bug Fixes
Chores
Documentation